Skip to content

[PWGHF] correlatorLcScHadrons: Fix TOF condition and improve candidate check logic - #17201

Merged
singhra1994 merged 1 commit into
AliceO2Group:masterfrom
singhra1994:master
Jul 26, 2026
Merged

[PWGHF] correlatorLcScHadrons: Fix TOF condition and improve candidate check logic#17201
singhra1994 merged 1 commit into
AliceO2Group:masterfrom
singhra1994:master

Conversation

@singhra1994

@singhra1994 singhra1994 commented Jul 25, 2026 •
edited by vkucera
Loading

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwghf PWG-HF label Jul 25, 2026
@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@singhra1994
singhra1994 enabled auto-merge (squash) July 25, 2026 21:27
alibuild
alibuild approved these changes Jul 25, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @singhra1994.

@vkucera
vkucera disabled auto-merge July 25, 2026 21:28
@vkucera vkucera changed the title [PWGHF] correlatorLcScHadrons Fix TOF condition and improve candidate… [PWGHF] correlatorLcScHadrons Fix TOF condition and improve candidate check logic Jul 25, 2026
@vkucera vkucera changed the title [PWGHF] correlatorLcScHadrons Fix TOF condition and improve candidate check logic [PWGHF] correlatorLcScHadrons: Fix TOF condition and improve candidate check logic Jul 25, 2026
@vkucera

vkucera commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

@singhra1994 Check the PR title before you enable merging.

@singhra1994
singhra1994 merged commit f6b93e9 into AliceO2Group:master Jul 26, 2026
20 of 21 checks passed
@alibuild

alibuild commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for de311e9 at 2026-07-26 11:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/8e692a6f0db970a33071ba384c7c392d18e0e8ab/O2Physics-code-check/errors.txt
PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:1857:9: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:1858:9: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

@singhra1994 Please fix the errors.

@singhra1994

singhra1994 commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

@singhra1994 Please fix the errors.

Okay in next version, I will implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singhra1994 @vkucera @alibuild